Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Userscript - New (spring 2024) UI support #1046

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

theblackhole
Copy link
Contributor

@theblackhole theblackhole commented Apr 17, 2024

Add support for new UI. (See extension issue #1043)

Tested with both new and old UI (since it's in a A/B testing phase) on Windows with :

  • Firefox Dev 125.0b6 (Tampermonkey 5.1.0)
  • Edge Dev 125.0.2518.0 (Tampermonkey 5.1.0)
  • Chrome 124.0.6367.61 (PortableApps version - Tampermonkey 5.1.0)

And on Linux (KUbuntu) with :

  • Firefox Dev 125.0.1 (Tampermonkey 5.1.0)
  • Edge Dev 125.0.2492.1 (Tampermonkey 5.1.0)

Preview of the userscript working with the new UI:
userscript

@Anarios
Copy link
Owner

Anarios commented Apr 18, 2024

Thanks!

Could you please format it with prettier, so that there are less formatting changes, and only the actual code changes in PR?

Nevermind, I'll merge it like this and format later, to release it faster.

@Anarios Anarios merged commit 63a8b28 into Anarios:main Apr 18, 2024
@Anarios
Copy link
Owner

Anarios commented Apr 18, 2024

Submitted this version for review

@Anarios
Copy link
Owner

Anarios commented Apr 18, 2024

@theblackhole
Copy link
Contributor Author

theblackhole commented Apr 18, 2024

Submitted this version for review

Hi @Anarios
I made 2 separate PRs, one for the Userscript (this one, #1046) and one for browser extensions (#1045) and I think you merged the wrong PR for the extension update 😁 (I tested your release and my changes doesn't appear in the popup.js file)

Sorry I should have specified it at the beginning of these 2 PRs

~Could you please format it with prettier, so that there are less formatting changes, and only the actual code changes in PR?

Yeah the precommit hooks already took care of this. And the huge Prettier changes surprised me, that's why I made 2 separate commits :

  • One without precommit hooks (=without the automatic Prettier task, via git commit -n) : 17f5bdf which contains only the functionnality changes
  • One with the precommit hooks (auto formatting tasks) : a1e6480
    So if you want me to revert the Prettier commit (or if you want to do it yourself), it'll be easy and won't impact the fix provided by this PR :)

BTW I did the same with the other (browser extensions) PR (#1045) so if you want me to revert the Prettier commit before merging, I can do that ;)

Another clarification: there is no version bump in my two PRs (I always leave it to the maintainer) so you'll need to bump this Userscript version :)

@Anarios
Copy link
Owner

Anarios commented Apr 18, 2024

Woah, yep, thanks for catching.

@Anarios
Copy link
Owner

Anarios commented Apr 18, 2024

https://github.com/Anarios/return-youtube-dislike/releases/tag/v3.0.0.16 is created now.

@theblackhole
Copy link
Contributor Author

Woah, yep, thanks for catching.

No problem :)

Copy link

@Bolshau Bolshau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@Bolshau Bolshau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants